[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

[via lldb-commits]

dlav-sc wrote:

> And this error is what exactly, what did we previously do and what does this PR now make us do?
> 
> I'm of course wondering if this can be tested too but let's be clear what's being fixed first and I'll see whether it can be added to some existing tests.

In my case lldb-server can't open file on a remote machine. Lldb client sends vFile:open message on the server, server tries to open a file, but receives ETXTBSY error. Lldb-server just checks that errno corresponding to some posix error 
(`if (code.category() == std::system_category())`) and if it so sends reply message with that posix error code, like it was with ETXTBSY. Then client receives this reply message, it tries to map errno on gdb rsp supported I/O-File error codes (which are in fact a limited set of posix errors that can occur then working with file). The problem is that gdb rsp doesn't has ETXTBSY in the list of supported errors https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html#Errno-Values, so in this cases the error is considered as unknown. 
Currently, I am working on the patch, that in some cases fix ETXTBSY error, and at the beginning it was hard for me to understand what the problem is, so I've decided try to make error messages more clear.

I have an idea to just add ETXTBSY error code into gdb rsp and then add it here, but maybe there is another errors like ETXTBSY that can appear in I/O-File messages, so I have decided to handle it in such way.

https://github.com/llvm/llvm-project/pull/106950