[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff a777a93118a0ca71e19ac764a57a94f1be227dbb 854bd34a797fabe0f03234d23eb566eb10d4b593 --extensions h,cpp -- lldb/include/lldb/API/SBError.h lldb/include/lldb/API/SBValueList.h lldb/include/lldb/Core/ValueObjectConstResult.h lldb/include/lldb/Expression/DiagnosticManager.h lldb/include/lldb/Target/Process.h lldb/include/lldb/Utility/Status.h lldb/source/API/SBBreakpoint.cpp lldb/source/API/SBBreakpointLocation.cpp lldb/source/API/SBBreakpointName.cpp lldb/source/API/SBDebugger.cpp lldb/source/API/SBError.cpp lldb/source/API/SBFile.cpp lldb/source/API/SBFormat.cpp lldb/source/API/SBFrame.cpp lldb/source/API/SBPlatform.cpp lldb/source/API/SBProcess.cpp lldb/source/API/SBSaveCoreOptions.cpp lldb/source/API/SBStructuredData.cpp lldb/source/API/SBTarget.cpp lldb/source/API/SBThread.cpp lldb/source/API/SBValue.cpp lldb/source/API/SBValueList.cpp lldb/source/API/SBWatchpoint.cpp lldb/source/Breakpoint/BreakpointLocation.cpp lldb/source/Commands/CommandObjectCommands.cpp lldb/source/Commands/CommandObjectMemoryTag.cpp lldb/source/Core/Debugger.cpp lldb/source/Core/ModuleList.cpp lldb/source/Core/PluginManager.cpp lldb/source/Core/ThreadedCommunication.cpp lldb/source/Core/ValueObject.cpp lldb/source/Core/ValueObjectCast.cpp lldb/source/Core/ValueObjectConstResult.cpp lldb/source/Core/ValueObjectDynamicValue.cpp lldb/source/Core/ValueObjectSyntheticFilter.cpp lldb/source/DataFormatters/VectorType.cpp lldb/source/Expression/DiagnosticManager.cpp lldb/source/Expression/ExpressionParser.cpp lldb/source/Expression/FunctionCaller.cpp lldb/source/Expression/LLVMUserExpression.cpp lldb/source/Expression/Materializer.cpp lldb/source/Expression/UserExpression.cpp lldb/source/Expression/UtilityFunction.cpp lldb/source/Host/common/LockFileBase.cpp lldb/source/Host/common/NativeProcessProtocol.cpp lldb/source/Host/common/TCPSocket.cpp lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp lldb/source/Interpreter/CommandInterpreter.cpp lldb/source/Interpreter/OptionValueRegex.cpp lldb/source/Interpreter/ScriptInterpreter.cpp lldb/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp lldb/source/Plugins/Platform/Android/AdbClient.cpp lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedProcessPythonInterface.cpp lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp lldb/source/Target/ModuleCache.cpp lldb/source/Target/Platform.cpp lldb/source/Target/Process.cpp lldb/source/Target/StackFrame.cpp lldb/source/Target/Target.cpp lldb/source/Target/Thread.cpp lldb/source/Utility/Status.cpp lldb/source/Utility/StructuredData.cpp lldb/unittests/Expression/DiagnosticManagerTest.cpp lldb/unittests/Target/RemoteAwarePlatformTest.cpp lldb/unittests/TestingSupport/Host/NativeProcessTestUtils.h lldb/unittests/Utility/StatusTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Expression/DiagnosticManager.cpp b/lldb/source/Expression/DiagnosticManager.cpp
index 6ad589aa7f..10d2be4678 100644
--- a/lldb/source/Expression/DiagnosticManager.cpp
+++ b/lldb/source/Expression/DiagnosticManager.cpp
@@ -19,7 +19,6 @@ std::string DetailedExpressionError::message() const {
   return m_detail.rendered;
 }
 
-
 static const char *StringForSeverity(lldb::Severity severity) {
   switch (severity) {
   // this should be exhaustive
@@ -33,7 +32,6 @@ static const char *StringForSeverity(lldb::Severity severity) {
   llvm_unreachable("switch needs another case for lldb::Severity enum");
 }
 
-
 void DiagnosticManager::Dump(Log *log) {
   if (!log)
     return;
@@ -76,8 +74,7 @@ DiagnosticManager::GetAsError(lldb::ExpressionResults result) const {
   return diags;
 }
 
-llvm::Error
-DiagnosticManager::GetAsError(llvm::Twine msg) const {
+llvm::Error DiagnosticManager::GetAsError(llvm::Twine msg) const {
   llvm::Error diags = llvm::createStringError(msg);
   for (const auto &diagnostic : m_diagnostics)
     diags = llvm::joinErrors(std::move(diags), diagnostic->GetAsError());
diff --git a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
index 335eaa5ee9..a7e63c83e5 100644
--- a/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
+++ b/lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
@@ -864,7 +864,7 @@ uint32_t PlatformPOSIX::DoLoadImage(lldb_private::Process *process,
                                                  arguments,
                                                  diagnostics)) {
     error = Status::FromError(diagnostics.GetAsError(
-        "dlopen error: could not write function arguments:" ));
+        "dlopen error: could not write function arguments:"));
     return LLDB_INVALID_IMAGE_TOKEN;
   }
   

``````````

</details>


https://github.com/llvm/llvm-project/pull/106442