[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

[Alex Langford via lldb-commits]

================
@@ -97,7 +97,7 @@ class LLDB_API SBError {
   friend class lldb_private::ScriptInterpreter;
   friend class lldb_private::python::SWIGBridge;
 
-  SBError(const lldb_private::Status &error);
+  SBError(lldb_private::Status &&error);
----------------
bulbazord wrote:

I have no concerns about Unix-ish platforms, but Windows may be a problem. I know that MSVC's mangling scheme includes access level (private/protected/public), which makes me think that private/protected symbols may be difficult to change while keeping ABI stable on MSVC.
Certainly SBAPI users and libraries shouldn't even be able to use this symbol, but I don't know if Windows will be unhappy that a private symbol changed.

@compnerd Do you have any insight here?

https://github.com/llvm/llvm-project/pull/106774