[Lldb-commits] [lldb] Add no-op handing for HLSLAttributedResource switch cases (PR #106698)

Danial Klimkin via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 30 02:50:44 PDT 2024


https://github.com/dklimkin created https://github.com/llvm/llvm-project/pull/106698

New value added in e00e9a3f8294c9b96cb0328bf136fab72aeec749

>From 241469a4e639a95caed22605d59728e605d09db5 Mon Sep 17 00:00:00 2001
From: Danial Klimkin <dklimkin at google.com>
Date: Fri, 30 Aug 2024 11:36:16 +0200
Subject: [PATCH 1/3] Add no-op handing for HLSLAttributedResource switch case

New value added in e00e9a3f8294c9b96cb0328bf136fab72aeec749
---
 lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 695801da9da69a..2368d6f8aa5b7f 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -4242,6 +4242,10 @@ TypeSystemClang::GetTypeClass(lldb::opaque_compiler_type_t type) {
   case clang::Type::PackIndexing:
     break;
   }
+
+  case clang::Type::HLSLAttributedResource:
+    break;
+  
   // We don't know hot to display this type...
   return lldb::eTypeClassOther;
 }

>From dd29bc792588fd23000985120e832242c14c07fb Mon Sep 17 00:00:00 2001
From: Danial Klimkin <dklimkin at google.com>
Date: Fri, 30 Aug 2024 11:42:03 +0200
Subject: [PATCH 2/3] Two more cases

---
 .../Plugins/TypeSystem/Clang/TypeSystemClang.cpp      | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 2368d6f8aa5b7f..6efa1b2c4b7859 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -4241,11 +4241,11 @@ TypeSystemClang::GetTypeClass(lldb::opaque_compiler_type_t type) {
   // We don't handle pack indexing yet
   case clang::Type::PackIndexing:
     break;
-  }
 
   case clang::Type::HLSLAttributedResource:
     break;
-  
+  }
+ 
   // We don't know hot to display this type...
   return lldb::eTypeClassOther;
 }
@@ -5152,6 +5152,9 @@ lldb::Encoding TypeSystemClang::GetEncoding(lldb::opaque_compiler_type_t type,
   // We don't handle pack indexing yet
   case clang::Type::PackIndexing:
     break;
+
+  case clang::Type::HLSLAttributedResource:
+    break;
   }
   count = 0;
   return lldb::eEncodingInvalid;
@@ -5314,6 +5317,10 @@ lldb::Format TypeSystemClang::GetFormat(lldb::opaque_compiler_type_t type) {
   case clang::Type::PackIndexing:
     break;
   }
+
+  case clang::Type::HLSLAttributedResource:
+    break;
+  
   // We don't know hot to display this type...
   return lldb::eFormatBytes;
 }

>From af49efdf83539b2819d23626a16f2388b012446a Mon Sep 17 00:00:00 2001
From: Danial Klimkin <dklimkin at google.com>
Date: Fri, 30 Aug 2024 11:48:24 +0200
Subject: [PATCH 3/3] Update TypeSystemClang.cpp

---
 lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 6efa1b2c4b7859..b0f49ebf2d2cbb 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -4245,7 +4245,6 @@ TypeSystemClang::GetTypeClass(lldb::opaque_compiler_type_t type) {
   case clang::Type::HLSLAttributedResource:
     break;
   }
- 
   // We don't know hot to display this type...
   return lldb::eTypeClassOther;
 }
@@ -5316,11 +5315,10 @@ lldb::Format TypeSystemClang::GetFormat(lldb::opaque_compiler_type_t type) {
   // We don't handle pack indexing yet
   case clang::Type::PackIndexing:
     break;
-  }
 
   case clang::Type::HLSLAttributedResource:
     break;
-  
+  }
   // We don't know hot to display this type...
   return lldb::eFormatBytes;
 }



More information about the lldb-commits mailing list