[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 29 11:30:18 PDT 2024


================
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line,
     }
 
     ElapsedTime elapsed(execute_time);
-    cmd_obj->Execute(remainder.c_str(), result);
+    size_t nchar = real_original_command_string.find(remainder);
+    std::optional<uint16_t> pos_in_cmd;
+    if (nchar != std::string::npos)
+      pos_in_cmd = nchar + GetDebugger().GetPrompt().size();
+    cmd_obj->Execute(remainder.c_str(), pos_in_cmd, result);
----------------
jimingham wrote:

Also, how does this work if I run

expr -i 0 -u 0 -- not a valid expression

The command string here is `-i 0 -u 0 -- not a valid expression` but you probably don't ever echo that full line onto the diagnostic, so either you are fudging and only matching the args part of the command, or the docs aren't right here.

https://github.com/llvm/llvm-project/pull/106470


More information about the lldb-commits mailing list