[Lldb-commits] [lldb] [lldb] Add Status::Detail to store expression evaluator diagnostics [… (PR #106442)

[Pavel Labath via lldb-commits]

labath wrote:

Not really (although this might work as well). What I meant was that, AIUI you're doing this so that you can plumb structured error information from one place (clang expression parser?) to another place (the thing which generates the expression errors -- I guess somewhere CommandObjectExpression?). That could be done by creating a (custom) llvm::Error in the first place, and consuming it in the second one *and* by making sure that all of the functions along that path don't lose this information by converting the error to a lldb_private::Status. I haven't looked at how hard much changes would that require, but I'm hoping that will be a single relatively well defined path that can be ported with reasonable effort. Even if there's e.g. a virtual function somewhere along the path, we don't necessarily have to port all implementations of that function immediately. We could just port the ones we need, and provide a shim so that the other implementations can remain unchanged...

https://github.com/llvm/llvm-project/pull/106442