[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

[Adrian Prantl via lldb-commits]

================
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line,
     }
 
     ElapsedTime elapsed(execute_time);
-    cmd_obj->Execute(remainder.c_str(), result);
+    size_t nchar = real_original_command_string.find(remainder);
+    std::optional<uint16_t> pos_in_cmd;
+    if (nchar != std::string::npos)
+      pos_in_cmd = nchar + GetDebugger().GetPrompt().size();
+    cmd_obj->Execute(remainder.c_str(), pos_in_cmd, result);
----------------
adrian-prantl wrote:

I can (and I thought the same thing as I was making the change), but I want to make sure that's the right API design. Reducing the size of the patch isn't necessarily a priority for me. Do we think that hiding the parameter in the object is a better design?

https://github.com/llvm/llvm-project/pull/106470