[Lldb-commits] [lldb] c954306 - [lldb][lldb-dap][test] Enable more tests on Windows

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 29 00:37:26 PDT 2024


Author: David Spickett
Date: 2024-08-29T07:37:02Z
New Revision: c954306ef763eb25f06432324889bde98735963d

URL: https://github.com/llvm/llvm-project/commit/c954306ef763eb25f06432324889bde98735963d
DIFF: https://github.com/llvm/llvm-project/commit/c954306ef763eb25f06432324889bde98735963d.diff

LOG: [lldb][lldb-dap][test] Enable more tests on Windows

These tests "just work" on our Windows On Arm machine.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_logpoints.py
    lldb/test/API/tools/lldb-dap/console/TestDAP_console.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_logpoints.py b/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_logpoints.py
index 78ceb7971112e5..33e7dcbe1b3b2f 100644
--- a/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_logpoints.py
+++ b/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_logpoints.py
@@ -19,7 +19,6 @@ def setUp(self):
         self.main_basename = "main-copy.cpp"
         self.main_path = os.path.realpath(self.getBuildArtifact(self.main_basename))
 
-    @skipIfWindows
     def test_logmessage_basic(self):
         """Tests breakpoint logmessage basic functionality."""
         before_loop_line = line_number("main.cpp", "// before loop")

diff  --git a/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py b/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
index 9e64dfe1daf0e3..8bbab8d0991dee 100644
--- a/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
+++ b/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
@@ -37,7 +37,6 @@ def check_lldb_command(
             ),
         )
 
-    @skipIfWindows
     def test_scopes_variables_setVariable_evaluate(self):
         """
         Tests that the "scopes" request causes the currently selected
@@ -80,7 +79,6 @@ def test_scopes_variables_setVariable_evaluate(self):
 
         self.check_lldb_command("frame select", "frame #1", "frame 1 is selected")
 
-    @skipIfWindows
     def test_custom_escape_prefix(self):
         program = self.getBuildArtifact("a.out")
         self.build_and_launch(program, commandEscapePrefix="::")
@@ -96,7 +94,6 @@ def test_custom_escape_prefix(self):
             command_escape_prefix="::",
         )
 
-    @skipIfWindows
     def test_empty_escape_prefix(self):
         program = self.getBuildArtifact("a.out")
         self.build_and_launch(program, commandEscapePrefix="")
@@ -151,7 +148,6 @@ def test_exit_status_message_sigterm(self):
             "Exit status does not contain message 'exited with status'",
         )
 
-    @skipIfWindows
     def test_exit_status_message_ok(self):
         program = self.getBuildArtifact("a.out")
         self.build_and_launch(program, commandEscapePrefix="")


        


More information about the lldb-commits mailing list