[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

[LLVM Continuous Integration via lldb-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `publish-sphinx-docs` running on `as-worker-4` while building `lldb` at step 5 "build-docs-llvm-html-docs-clang-html-docs-clang-tools-html-docs-lld-html-docs-lldb-html-docs-flang-html-docs-openmp-html-docs-polly-html".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/45/builds/3265

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-docs-llvm-html-docs-clang-html-docs-clang-tools-html-docs-lld-html-docs-lldb-html-docs-flang-html-docs-openmp-html-docs-polly-html) failure: build (failure)
...
1284.342 [980/24/3989] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/StringExtractor.cpp.o
1284.374 [979/24/3990] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Stream.cpp.o
1284.589 [978/24/3991] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Listener.cpp.o
1284.800 [977/24/3992] Building CXX object tools/clang/lib/Frontend/Rewrite/CMakeFiles/obj.clangRewriteFrontend.dir/RewriteModernObjC.cpp.o
1284.818 [976/24/3993] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/ProcessInfo.cpp.o
1284.918 [975/24/3994] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/StringExtractorGDBRemote.cpp.o
1284.928 [974/24/3995] Generating html Sphinx documentation for flang into "/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/flang/docs/html"
1284.990 [973/24/3996] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/RegisterValue.cpp.o
1285.023 [972/24/3997] Generating VCSVersion.inc
1285.338 [971/24/3998] Building CXX object tools/lldb/source/Plugins/Platform/QemuUser/CMakeFiles/lldbPluginPlatformQemuUser.dir/PlatformQemuUser.cpp.o
FAILED: tools/lldb/source/Plugins/Platform/QemuUser/CMakeFiles/lldbPluginPlatformQemuUser.dir/PlatformQemuUser.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/source/Plugins/Platform/QemuUser -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/Platform/QemuUser -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/../clang/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/../clang/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/source -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -std=c++17 -MD -MT tools/lldb/source/Plugins/Platform/QemuUser/CMakeFiles/lldbPluginPlatformQemuUser.dir/PlatformQemuUser.cpp.o -MF tools/lldb/source/Plugins/Platform/QemuUser/CMakeFiles/lldbPluginPlatformQemuUser.dir/PlatformQemuUser.cpp.o.d -o tools/lldb/source/Plugins/Platform/QemuUser/CMakeFiles/lldbPluginPlatformQemuUser.dir/PlatformQemuUser.cpp.o -c /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp
In file included from /usr/include/c++/9/memory:80,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include/llvm/ADT/STLExtras.h:37,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include/llvm/Support/FormatProviders.h:17,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/lldb-private-enumerations.h:15,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/lldb-private.h:12,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Host/Terminal.h:12,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Host/File.h:13,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Host/Host.h:12,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.h:12,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:9:
/usr/include/c++/9/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = lldb_private::UserExpression]’:
/usr/include/c++/9/bits/unique_ptr.h:292:17:   required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = lldb_private::UserExpression; _Dp = std::default_delete<lldb_private::UserExpression>]’
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Symbol/TypeSystem.h:502:12:   required from here
/usr/include/c++/9/bits/unique_ptr.h:79:16: error: invalid application of ‘sizeof’ to incomplete type ‘lldb_private::UserExpression’
   79 |  static_assert(sizeof(_Tp)>0,
      |                ^~~~~~~~~~~
1285.389 [971/23/3999] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/UnimplementedError.cpp.o
1285.400 [971/22/4000] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/TildeExpressionResolver.cpp.o
1285.501 [971/21/4001] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/UriParser.cpp.o
1285.643 [971/20/4002] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Timer.cpp.o
1285.665 [971/19/4003] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/UUID.cpp.o
1285.719 [971/18/4004] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/UserID.cpp.o
1285.743 [971/17/4005] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/FileSpecList.cpp.o
FAILED: tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/FileSpecList.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/source/Utility -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Utility -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/../clang/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/../clang/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/source -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -std=c++17 -MD -MT tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/FileSpecList.cpp.o -MF tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/FileSpecList.cpp.o.d -o tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/FileSpecList.cpp.o -c /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Utility/FileSpecList.cpp
In file included from /usr/include/c++/9/memory:80,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include/llvm/ADT/SmallVector.h:28,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:13,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include/llvm/Support/FormatVariadic.h:28,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Utility/ConstString.h:14,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Utility/FileSpec.h:16,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Utility/FileSpecList.h:12,
                 from /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Utility/FileSpecList.cpp:9:
/usr/include/c++/9/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = lldb_private::UserExpression]’:
/usr/include/c++/9/bits/unique_ptr.h:292:17:   required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = lldb_private::UserExpression; _Dp = std::default_delete<lldb_private::UserExpression>]’
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include/lldb/Symbol/TypeSystem.h:502:12:   required from here
/usr/include/c++/9/bits/unique_ptr.h:79:16: error: invalid application of ‘sizeof’ to incomplete type ‘lldb_private::UserExpression’

```

</details>

https://github.com/llvm/llvm-project/pull/106034