[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

Tue Aug 27 12:20:40 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/6005

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
33.001 [1386/50/5533] Building CXX object unittests/Analysis/InlineAdvisorPlugin/CMakeFiles/InlineAdvisorPlugin.dir/InlineAdvisorPlugin.cpp.o
33.001 [1386/49/5534] Building CXX object unittests/Analysis/InlineOrderPlugin/CMakeFiles/InlineOrderPlugin.dir/InlineOrderPlugin.cpp.o
33.001 [1386/48/5535] Building CXX object unittests/Passes/Plugins/DoublerPlugin/CMakeFiles/DoublerPlugin.dir/DoublerPlugin.cpp.o
33.063 [1386/47/5536] Building CXX object tools/lldb/tools/lldb-instr/CMakeFiles/lldb-instr.dir/Instrument.cpp.o
33.620 [1386/46/5537] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/LockFileBase.cpp.o
33.624 [1386/45/5538] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/HostThread.cpp.o
33.720 [1386/44/5539] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/LockFilePosix.cpp.o
33.730 [1386/43/5540] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/HostThreadPosix.cpp.o
33.784 [1386/42/5541] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/linux/AbstractSocket.cpp.o
33.788 [1386/41/5542] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/SelectHelper.cpp.o
FAILED: tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/SelectHelper.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/source/Utility -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/source/Utility -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/include -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/../clang/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/../clang/include -I/usr/include/libxml2 -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/source -I/b/1/llvm-x86_64-debian-dylib/build/tools/lldb/source -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/SelectHelper.cpp.o -MF tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/SelectHelper.cpp.o.d -o tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/SelectHelper.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/source/Utility/SelectHelper.cpp
/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/source/Utility/SelectHelper.cpp:115:11: error: use of undeclared identifier 'Status'; did you mean 'lldb_private::Status'?
          Status::FromErrorStringWithFormat("%i is too large for select()", fd);
          ^~~~~~
          lldb_private::Status
/b/1/llvm-x86_64-debian-dylib/llvm-project/lldb/include/lldb/Utility/Status.h:44:7: note: 'lldb_private::Status' declared here
class Status {
      ^
1 error generated.
33.834 [1386/40/5543] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/ThreadLauncher.cpp.o
33.842 [1386/39/5544] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/PipeBase.cpp.o
33.849 [1386/38/5545] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/MainLoopBase.cpp.o
33.854 [1386/37/5546] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/StringExtractorGDBRemote.cpp.o
33.884 [1386/36/5547] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/DomainSocket.cpp.o
33.959 [1386/35/5548] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/NativeWatchpointList.cpp.o
34.043 [1386/34/5549] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/HostProcess.cpp.o
34.055 [1386/33/5550] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Status.cpp.o
34.218 [1386/32/5551] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/UDPSocket.cpp.o
34.240 [1386/31/5552] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/HostNativeThreadBase.cpp.o
34.240 [1386/30/5553] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/Alarm.cpp.o
34.246 [1386/29/5554] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/PseudoTerminal.cpp.o
34.298 [1386/28/5555] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/ZipFileResolver.cpp.o
34.310 [1386/27/5556] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/FileSystemPosix.cpp.o
34.338 [1386/26/5557] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/FileCache.cpp.o
34.366 [1386/25/5558] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/RegisterValue.cpp.o
34.375 [1386/24/5559] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/MainLoopPosix.cpp.o
34.468 [1386/23/5560] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/Socket.cpp.o
34.481 [1386/22/5561] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/TCPSocket.cpp.o
34.490 [1386/21/5562] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/HostProcessPosix.cpp.o
34.671 [1386/20/5563] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/FileSystem.cpp.o
34.686 [1386/19/5564] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/StreamFile.cpp.o
34.690 [1386/18/5565] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/linux/HostInfoLinux.cpp.o
34.691 [1386/17/5566] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/NativeThreadProtocol.cpp.o
34.844 [1386/16/5567] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/posix/PipePosix.cpp.o
34.860 [1386/15/5568] Building CXX object tools/lldb/source/Utility/CMakeFiles/lldbUtility.dir/Scalar.cpp.o
35.017 [1386/14/5569] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/NativeRegisterContext.cpp.o
35.089 [1386/13/5570] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/MonitoringProcessLauncher.cpp.o
35.107 [1386/12/5571] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/File.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/106163