[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 27 03:39:55 PDT 2024


labath wrote:

I like this. I have just two remarks:
- it might be better to split this into three steps (add new APIs, port to new APIs, remove old APIs), as that will make reverts easier/less disruptive (I don't know how much we can trust pre-commit CI these days, but I wouldn't be surprised if this breaks some platform-specific code).
- since this seems like a perfect opportunity to bikesh^Wdiscuss the names, I'm going to ask if there's any appetite for shortening some of the new factory functions. `Status::FromErrorStringWithFormatv` is a bit of a mouthful, so I was thinking if we could  use something shorter instead (`Status::FromFormatv` or even `Status::Formatv`) ?

https://github.com/llvm/llvm-project/pull/106163


More information about the lldb-commits mailing list