[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 26 22:08:06 PDT 2024


clayborg wrote:

I wonder if this needs to default to column 1? We might end up adding column zero. 
```
  /**
   * Start position of the range covered by the stack frame. It is measured in
   * UTF-16 code units and the client capability `columnsStartAt1` determines
   * whether it is 0- or 1-based. If attribute `source` is missing or doesn't
   * exist, `column` is 0 and should be ignored by the client.
   */
  column: number;
```
So if we return zero, it might cause a problem as the `InitializeRequestArguments` contains:
```
  /**
   * If true all column numbers are 1-based (default).
   */
  columnsStartAt1?: boolean;
```

1 is the default, and if we return zero, this could cause a problem?

https://github.com/llvm/llvm-project/pull/73393


More information about the lldb-commits mailing list