[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Sun Aug 18 23:12:16 PDT 2024


medismailben wrote:

> Okay, that sort of makes sense. However, unless you actually want to be able to disable each of these plugins independently (which it sounds like you don't), then this is a very.. baroque way to achieve the desired effect (to have multiple (plugin) classes registered with the plugin manager).
> 
> All of that cmake plugin logic is just a very elaborate way to invoke `SomeClass::Initialize()`. Plugins are registered through `PluginManager::RegisterPlugin`. While the usual case is that the `Initialize` function performs a single `RegisterPlugin` call (and pretty much nothing else), nothing actually depends or enforces that, and we do have "plugins" where a single plugin library registers more than plugin class (e.g. `lldbPluginPlatformMacOSX`). I think it would be perfectly reasonable to register all of these classes from `ScriptInterpreterPythonInterfaces::Initialize` (and maybe even from `ScriptInterpreterPython::Initialize`).

I was on vacation last week, I try to give a stab a this tomorrow, thanks for the suggestions :)

https://github.com/llvm/llvm-project/pull/101672


More information about the lldb-commits mailing list