[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Sun Aug 18 12:05:22 PDT 2024
================
@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions {
const path = vscode.workspace
.getConfiguration("lldb-dap", session.workspaceFolder)
.get<string>("executable-path");
- if (path) {
- return new vscode.DebugAdapterExecutable(path, []);
+
+ if (!path) {
+ return packageJSONExecutable;
+ }
+
+ try {
+ const fileStats = await fs.stat(path);
+ if (!fileStats.isFile()) {
----------------
JDevlieghere wrote:
I assume this will fail if the file is a symlink? Should this be
```
if (!fileStats.isFile() && !fileStats.isSymbolicLink()))
```
https://github.com/llvm/llvm-project/pull/104711
More information about the lldb-commits
mailing list