[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

[Dmitry Vasilyev via lldb-commits]

================
@@ -147,15 +147,8 @@ GDB-SERVER CONNECTIONS
 
 .. option:: --gdbserver-port <port>
 
- Define a port to be used for gdb-server connections. Can be specified multiple
- times to allow multiple ports. Has no effect if --min-gdbserver-port
- and --max-gdbserver-port are specified.
-
-.. option:: --min-gdbserver-port <port>
-.. option:: --max-gdbserver-port <port>
-
- Specify the range of ports that can be used for gdb-server connections. Both
- options need to be specified simultaneously. Overrides --gdbserver-port.
+ Define a port to be used for gdb-server connections. This port is used for
+ multiple connections.
----------------
slydiman wrote:

Before: 
- `lldb-server platform`
  - got the query `qLaunchGDBServer`
  - request a gdb port from the map (it may be 0)
  - launch `lldb-server gdbserver host:port`
  - if the port was 0, read the actual port back via pipe
  - answer OK and report the actual port and pid
- lldb client connects to gdbserver using host:port (if handshake failed, lldb client kills gdbserver by pid via platform protocol)

After:
- `lldb-server platform`
  - listen to gdbserver-port
  - got the query `qLaunchGDBServer`
  - answer OK and report always known gdbserver-port and ibvalid pid
- lldb client connects to gdbserver using host:port (do nothing if handshake failed)
- `lldb-server platform` got connection and launch `lldb-server gdbserver --fd socket`
  - `lldb-server platform` will transfer the socket info to gdbserver via pipe on Windows (or kill gdbserver if it failed)

https://github.com/llvm/llvm-project/pull/104238