[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 82ee31f75ac1316006fa9e21dddfddec37cf7072 a740c6918fd4c0e47b6d266fbb2b217112405a4f --extensions cpp,c,h -- lldb/test/API/tools/lldb-dap/locations/main.c lldb/tools/lldb-dap/DAP.cpp lldb/tools/lldb-dap/DAP.h lldb/tools/lldb-dap/JSONUtils.cpp lldb/tools/lldb-dap/JSONUtils.h lldb/tools/lldb-dap/lldb-dap.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp
index baf02e5b35..a773c2df28 100644
--- a/lldb/tools/lldb-dap/DAP.cpp
+++ b/lldb/tools/lldb-dap/DAP.cpp
@@ -839,8 +839,7 @@ lldb::SBValue Variables::GetVariable(int64_t var_ref) const {
   return lldb::SBValue();
 }
 
-int64_t Variables::InsertVariable(lldb::SBValue variable,
-                                  bool is_permanent) {
+int64_t Variables::InsertVariable(lldb::SBValue variable, bool is_permanent) {
   int64_t var_ref = GetNewVariableReference(is_permanent);
   if (is_permanent)
     referenced_permanent_variables.insert(std::make_pair(var_ref, variable));
diff --git a/lldb/tools/lldb-dap/JSONUtils.cpp b/lldb/tools/lldb-dap/JSONUtils.cpp
index 10e6b1fc6d..a7f40aee99 100644
--- a/lldb/tools/lldb-dap/JSONUtils.cpp
+++ b/lldb/tools/lldb-dap/JSONUtils.cpp
@@ -1163,7 +1163,8 @@ std::string VariableDescription::GetResult(llvm::StringRef context) {
 //       "properties": {
 //         "declaration": {
 //           "type": "object",
-//           "description": "The source location where the variable was declared.
+//           "description": "The source location where the variable was
+//           declared.
 //                           This value won't be present if no declaration is
 //                           available.
 //                           Superseded by `declarationLocationReference`",

``````````

</details>


https://github.com/llvm/llvm-project/pull/102928