[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

[Greg Clayton via lldb-commits]

================
@@ -29,10 +29,10 @@ ThreadPlanSingleThreadTimeout::ThreadPlanSingleThreadTimeout(
     : ThreadPlan(ThreadPlan::eKindSingleThreadTimeout, "Single thread timeout",
                  thread, eVoteNo, eVoteNoOpinion),
       m_info(info), m_state(State::WaitTimeout) {
-  // TODO: reuse m_timer_thread without recreation.
-  m_timer_thread = std::thread(TimeoutThreadFunc, this);
   m_info->m_isAlive = true;
   m_state = m_info->m_last_state;
----------------
clayborg wrote:

we now setup the state _prior_ to starting the thread which makes sense and this could have been the cause of the flakiness of the tests.

https://github.com/llvm/llvm-project/pull/104195