[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

I don't want to derail the conversation about this PR, but I've been wanting to overhaul our Target::ReadMemory and Process::ReadMemory API in lldb for months now, and haven't put together a coherent proposal for it yet.  I need to clear a few things off my task list and get started on this for real.  My main complaint about the existing API is that many people don't understand the difference between a Target memory read (may read from live memory, may read from the file as an optimization, or if the memory is inaccessible) versus a Process memory read (only read from live memory), and the fact that Process has several convenient access methods like ReadCStringFromMemory which Target doesn't have means people chose based on that.

I haven't thought about all the different parameters we need to allow people to specify yet, and how it's going to look in an API, but I think we need an API that doesn't depend on the Target/Process distinction to implicitly get one behavior over another.  I hope to think on this enough to get a proposal on a Discourse soon.

https://github.com/llvm/llvm-project/pull/102536