[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 14 07:15:39 PDT 2024


================
@@ -53,6 +53,27 @@ Expected<std::string> MinidumpFile::getString(size_t Offset) const {
   return Result;
 }
 
+Expected<std::vector<const minidump::ExceptionStream *>>
+MinidumpFile::getExceptionStreams() const {
----------------
labath wrote:

This looks like a job for an (non-fallible) input iterator returning an `Expected<const ExceptionStream&>`. (non-fallible, because the iteration always suceeds, but reading of any stream can fail, and can do so independendly of all other streams.)

Alternatively, maybe we could just return an array of minidump::Directory descriptors, and have the caller retrieve them one at a time via something like `getExceptionStream(Directory)`.

https://github.com/llvm/llvm-project/pull/97470


More information about the lldb-commits mailing list