[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 14 01:43:10 PDT 2024


================
@@ -258,6 +258,9 @@ class TypeSummaryImpl {
 
   virtual std::string GetDescription() = 0;
 
+  virtual ConstString GetName() = 0;
+  virtual ConstString GetImplType() = 0;
----------------
Michael137 wrote:

Could we use something more descriptive for the name? My expectation from a function called `GetImplType` is that it returns something other than a string, for example, an enum. So maybe something along the lines of `GetSummaryFormatKindName`?

https://github.com/llvm/llvm-project/pull/102708


More information about the lldb-commits mailing list