[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 13 23:03:00 PDT 2024


https://github.com/clayborg commented:

I vote to leave this PR as is because `VMRangeToFileOffset` is a list of VMRanges that map to file offsets and this list combines entries with consecutive address ranges whose data is consecutive in the core file. And `VMRangeToPermissions` does not break things up. So not sure how we could use memory regions with this. It would also make the patch really large to have `Process::ReadMemory` return a `DataExtractor` and change all code over to using that. I do like this idea and think that we should work on a patch that can do this because `PeekMemory` could easily set the data pointers within a `DataExtractor` without copying the data. 

https://github.com/llvm/llvm-project/pull/102536


More information about the lldb-commits mailing list