[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 13 22:49:02 PDT 2024
================
@@ -116,6 +116,9 @@ std::string StringSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+ConstString StringSummaryFormat::GetName() { return ConstString(m_format_str); }
+ConstString StringSummaryFormat::GetImplType() { return ConstString("string"); }
----------------
clayborg wrote:
We should switch to `std::string` instead of `ConstString.. These objects aren't starting out as ConstString objects. We only want to use ConstString objects for things we are searching for by name where there will be many copies of the string.
https://github.com/llvm/llvm-project/pull/102708
More information about the lldb-commits
mailing list