[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 13 22:49:01 PDT 2024


================
@@ -258,6 +258,9 @@ class TypeSummaryImpl {
 
   virtual std::string GetDescription() = 0;
 
+  virtual ConstString GetName() = 0;
+  virtual ConstString GetImplType() = 0;
+
----------------
clayborg wrote:

We should switch to `std::string` instead of `ConstString.. These objects that get returned here don't start out as `ConstString` objects. We only want to use `ConstString` objects for things we are comparing many things by name where there will be many instances of objects that have this name.

https://github.com/llvm/llvm-project/pull/102708


More information about the lldb-commits mailing list