[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

[Dmitrii Galimzianov via lldb-commits]

DmT021 wrote:

Oh, wait a sec. I actually changed the behavior of the `IRExecutionUnit::FindInSymbols`. It used to exit early if the function was found in `module_sp`, but now we will always scan through the whole ModuleList.
And we can't change the behavior `ModuleList::FindFunctions` to return after the first match, because it might be not what we want in general case.
Maybe I should add more generic versions of these functions taking a callback to invoke on each match instead of SymbolContextList? Something like
```
void ModuleList::FindSymbolsWithNameAndType(
  ConstString name,
  lldb::SymbolType symbol_type,
  const SymbolContext *search_hint,
  llvm::function_ref<bool(const Symbol&)> callback
  )
```
where the result of `callback` indicates whether the search should be continued or not.

https://github.com/llvm/llvm-project/pull/102835