[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)
Dmitrii Galimzianov via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 13 06:32:27 PDT 2024
================
@@ -285,7 +285,7 @@ class ModuleList {
/// \see Module::FindFunctions ()
void FindFunctions(ConstString name, lldb::FunctionNameType name_type_mask,
const ModuleFunctionSearchOptions &options,
- SymbolContextList &sc_list) const;
+ const SymbolContext &sc, SymbolContextList &sc_list) const;
----------------
DmT021 wrote:
> How about we call sc, search_first instead, or something more self-documenting like that? (which is what FindTypes also does).
The word "hint" came up a couple times in the discussion as well. Maybe `search_hint` ?
> could we add documentation to the function describing what the parameter does?
Sure.
https://github.com/llvm/llvm-project/pull/102835
More information about the lldb-commits
mailing list