[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

[Greg Clayton via lldb-commits]

https://github.com/clayborg commented:

Thanks for trying this, and yes, this is exactly what I was thinking!

After seeing all of the code changes that this created, I suggested in ModuleList.h that we add a the symbol context as a default parameter to the functions  as `const SymbolContext *sc = nullptr`. If we do this, most of the changes in this diff go away and it will be small again. Also if the symbol context comes in a as a pointer, users can know that this parameter is optional and it is ok for it to be `nullptr`, where it might not be clear to users that they can pass in a default constructed SymbolContext. 

Thanks for the changes, this improves this patch quite a bit and I think with a few more modifications this will be a small patch again. 

Thanks again! I look forward to seeing the next round of changes.

https://github.com/llvm/llvm-project/pull/102835