[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

Augusto Noronha via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 12 16:09:32 PDT 2024


augusto2112 wrote:

I agree that passing some sort of "hint" object to prioritize the search would be a more complete solution, but since this is @DmT021's first contribution to LLVM I think we should merge this change if there are no concerns with the current implementation, and if @DmT021 wants to expand on a more general solution for the `Find...` family of functions he could work on that on a separate patch.

@clayborg I can see how a module could be used as a hint, but I'm not sure how we'd prioritize lookups using functions or compile unit. The code in `SymTab.cpp` does a binary search to find the symbol, how could we restrict this further by passing a function hint, for example?

https://github.com/llvm/llvm-project/pull/102835


More information about the lldb-commits mailing list