[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

[Michael Buch via lldb-commits]

https://github.com/Michael137 commented:

Generally, makes sense to me. Out of curiosity, could you provide some context around where/how this came up?

The ideal version of this would be a version of `FindFunctions`/`FindSymbolsWithNameAndType` that took a `ModuleSP` hint (aka where to search first). We already have such an API for `FindTypes` (which got introduced with the `TypeQuery` rework). We just never added one for the other `FindXXX` APIs because those weren't reworked to use `TypeQuery`.

Not sure it's worth adding that `search_first` parameter to all overloads of `FindFunctions`, but maybe that wouldn't look as awful as I think it might?

https://github.com/llvm/llvm-project/pull/102835