[Lldb-commits] [lldb] 513c372 - [lldb][test] Break early when walking backtrace in concurrent tests
David Spickett via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 12 06:18:26 PDT 2024
Author: David Spickett
Date: 2024-08-12T13:18:10Z
New Revision: 513c3726ebc0a324f7e5a11d25617bb9557324d6
URL: https://github.com/llvm/llvm-project/commit/513c3726ebc0a324f7e5a11d25617bb9557324d6
DIFF: https://github.com/llvm/llvm-project/commit/513c3726ebc0a324f7e5a11d25617bb9557324d6.diff
LOG: [lldb][test] Break early when walking backtrace in concurrent tests
We only need to see that 1 frame of the stack is in user code. No need
to carry on looking.
Doing so actually caused a test failure on Armv8 Ubuntu Jammy where
a libc function does not have a display name. I'm sure I'm going to
get stung by this elsewhere, but for this test, breaking early
sidesteps the problem.
Added:
Modified:
lldb/packages/Python/lldbsuite/test/concurrent_base.py
Removed:
################################################################################
diff --git a/lldb/packages/Python/lldbsuite/test/concurrent_base.py b/lldb/packages/Python/lldbsuite/test/concurrent_base.py
index 46d71666d06977..a45b4207a834b4 100644
--- a/lldb/packages/Python/lldbsuite/test/concurrent_base.py
+++ b/lldb/packages/Python/lldbsuite/test/concurrent_base.py
@@ -290,6 +290,10 @@ def do_thread_actions(
if funcname in f.GetDisplayFunctionName():
thread_has_user_code = True
break
+
+ if thread_has_user_code:
+ break
+
if thread_has_user_code:
num_threads_with_usercode += 1
More information about the lldb-commits
mailing list