[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 8 22:45:03 PDT 2024


================
@@ -1095,3 +1095,9 @@ bool ProcessElfCore::GetProcessInfo(ProcessInstanceInfo &info) {
   }
   return true;
 }
+
+const uint8_t *ProcessElfCore::PeekMemory(lldb::addr_t low, lldb::addr_t high,
----------------
clayborg wrote:

I commented in the header file, ArrayRef is a good idea. We might want a `std::optional<ArrayRef<uint8_t>>` where if something with no value is returned, it means that PeekMemory is not implemented and we should fall back to the original `Process::FindInMemory`

https://github.com/llvm/llvm-project/pull/102536


More information about the lldb-commits mailing list