[Lldb-commits] [lldb] [llvm] [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (PR #101272)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 8 01:08:35 PDT 2024


================
@@ -494,6 +528,23 @@ Stream::create(const Directory &StreamDesc, const object::MinidumpFile &File) {
     }
     return std::make_unique<MemoryListStream>(std::move(Ranges));
   }
+  case StreamKind::Memory64List: {
+    Error Err = Error::success();
+    auto Memory64List = File.getMemory64List(Err);
+    if (Err)
+      return Err;
----------------
labath wrote:

```suggestion
    auto Memory64List = File.getMemory64List(Err);
```

I think we can delete this check, as the error will be checked below, and we will get an empty iterator range in case of early fatal errors.

https://github.com/llvm/llvm-project/pull/101272


More information about the lldb-commits mailing list