[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #102309)

[Michael Buch via lldb-commits]

Michael137 wrote:

> This really isn't the right approach. `BuiltinHeadersInSystemModules` isn't the only important default that the driver sets up. Can we change the invocation setup to use clang::createInvocation or clang::CompilerInvocation::CreateFromArgs or clang::BuildCompilation? Or is that planned for another change?

Yes I 100% agree that we should use the driver. This has been a FIXME for many years now. But to unblock the current test failures I think this should be fine to land. And when we switch to using the driver properly we'll remove this.

https://github.com/llvm/llvm-project/pull/102309