[Lldb-commits] [lldb] [llvm] [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (PR #101272)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 7 01:13:46 PDT 2024


================
@@ -154,3 +155,33 @@ MinidumpFile::create(MemoryBufferRef Source) {
   return std::unique_ptr<MinidumpFile>(
       new MinidumpFile(Source, Hdr, *ExpectedStreams, std::move(StreamMap)));
 }
+
+Expected<iterator_range<MinidumpFile::FallibleMemory64Iterator>>
----------------
labath wrote:

Instead of returning another error inside the `Expected<T>`, maybe we could reuse the error out parameter -- just set that to whatever we encounter and return an empty range?

Something like:
```
ErrorAsOutParameter ErrAsOut(&Err);
Expected<T> ListHeader = ...;
if (!ListHeader) {
  Err = ListHeader.takeError();
  return make_fallible_range(Memory64Iterator::end(), Memory64Iterator::end(), Err);
}
```

https://github.com/llvm/llvm-project/pull/101272


More information about the lldb-commits mailing list