[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 6 09:01:40 PDT 2024


================
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler,
   lang_opts.NoBuiltin = true;
 }
 
-static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) {
+// NOTE: should be kept in sync with sdkSupportsBuiltinModules in
+// Toolchains/Darwin.cpp
+static bool
+sdkSupportsBuiltinModulesImpl(const llvm::Triple &triple,
----------------
Michael137 wrote:

Tbh I'd prefer keeping this as an implementation detail. We really don't want to duplicate this logic. And can hopefully remove it eventually. If it lives as an API in a header that has a slight chance of making it harder to remove.
But lmk if either of you feel strongly about it.

https://github.com/llvm/llvm-project/pull/101778


More information about the lldb-commits mailing list