[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 6 04:34:14 PDT 2024


================
@@ -788,7 +808,10 @@ Type::GetTypeScopeAndBasename(llvm::StringRef name) {
     switch (pos.value()) {
     case ':':
       if (prev_is_colon && template_depth == 0) {
-        result.scope.push_back(name.slice(name_begin, pos.index() - 1));
+        llvm::StringRef scope_name = name.slice(name_begin, pos.index() - 1);
----------------
Michael137 wrote:

Do I understand correctly that we could've kept this as-is, but would then have to check for the `(anonymous namespace)` string in the `ContextMatches` function?

Could we leave a comment on why this is necessary? E.g., how this string might end up in the parsed name (aka the demangler).

https://github.com/llvm/llvm-project/pull/102111


More information about the lldb-commits mailing list