[Lldb-commits] [lldb] [lldb/Interpreter] Fix ambiguous partial command resolution (PR #101934)
Med Ismail Bennani via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 5 10:38:40 PDT 2024
medismailben wrote:
> IIUC, you are adding a new rule that if an incoming command name has partial matches to one user command and one alias command, the user command is preferred over the alias command. Is that right?
Yes.
> You certainly should document that rule somewhere - maybe in the Tutorial section of the docs? Maybe in the help for `command alias`. And there should certainly be an explicit test to show this ordering - you can just use the script/scripting since that's what you added this for.
Indeed, I should document that.
> But I think I'm missing something, because I don't see how this solves the problem you set out to solve. You wanted to add the alias `script` to point to `scripting run`, and make `sc`, `scr`, etc also mean your alias. However, if I'm following your logic correctly, if I type `scr` then that matches the Alias command `script` -> `scripting run` and the user command `scripting`. By the logic in your path, it will choose the user command `scripting` not the alias, which I think is the opposite of what you wanted.
>
> I must be missing something.
Right, but I think commands added explicitly by the user, that overwrite other commands (or multiword commands in the `scripting` example), should have priority over the lldb defined commands and aliases.
https://github.com/llvm/llvm-project/pull/101934
More information about the lldb-commits
mailing list