[Lldb-commits] [lldb] [lldb] Fixed PipeWindows bugs; added Pipe::WriteWithTimeout() (PR #101383)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 5 04:22:24 PDT 2024


================
@@ -44,8 +42,70 @@ TEST_F(PipeTest, OpenAsReader) {
   size_t name_len = name.size();
   name += "foobar";
   llvm::StringRef name_ref(name.data(), name_len);
+  // Note OpenAsReader() do nothing on Windows, the pipe is already opened for
----------------
labath wrote:

Let's keep this change out of the patch. I think it'd be better to redesign this API to provide a better abstraction over the differences in system behavior.

https://github.com/llvm/llvm-project/pull/101383


More information about the lldb-commits mailing list