[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Fix ProcessMinidump::GetMemoryRegions to include 64b regions when /proc/pid maps are missing. (PR #101086)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 30 09:35:12 PDT 2024


labath wrote:

> > Sounds good. Could you split off the lldb parts to a separate review though?
> 
> @labath I think we need both, in order to fix `SBProcess` to return all memory regions we need the LLDB change, which enables us to test if the yaml2obj generates correctly

I can believe you need the llvm changes for the lldb test. That's fine and expected. You can make those changes on a separate PR. However, there shouldn't code in llvm which is only tested from lldb. That's why I pointed you to all the existing tests for yaml2minidump functionality in llvm. You can test the llvm functionality through those.

https://github.com/llvm/llvm-project/pull/101086


More information about the lldb-commits mailing list