[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 26 11:27:20 PDT 2024


================
@@ -6668,6 +6676,18 @@ Status Process::CalculateCoreFileSaveRanges(lldb::SaveCoreStyle core_style,
   return Status(); // Success!
 }
 
+std::vector<ThreadSP>
+Process::CalculateCoreFileThreadList(const SaveCoreOptions &core_options) {
+  std::vector<ThreadSP> thread_list;
+  for (const auto &thread : m_thread_list.Threads()) {
----------------
clayborg wrote:

change `const auto &thread ` to `const ThreadSP &thread_sp` to indicate "thread" is a shared pointer and not use `auto` unless it saves tons of text

https://github.com/llvm/llvm-project/pull/100443


More information about the lldb-commits mailing list