[Lldb-commits] [lldb] [lldb][test] Add ABI library to Makefile.rules link flags (PR #99589)

[Vladislav Dzhidzhoev via lldb-commits]

dzhidzhoev wrote:

> Libc++ supports a [large number](https://github.com/llvm/llvm-project/blob/6235698f47828747d3b1b0418e547e2e4ff9138f/libcxx/cmake/Modules/HandleLibCXXABI.cmake#L85) of configurations when in comes to the ABI library.
> 
> I think the most common are: shared-libcxx+shared-libcxxabi (where this change should be a no-op) and static-libcxx+static-libcxxabi (where this flag is required to build).
> 
> However, I also found evidence of configurations which embed the abi library into libcxx (which would break with this flag, as `-lc++abi` will find nothing, or the wrong library), or link the c++ library to the gnu abi library (libsupc++, where this flag would cause duplicate definitions or general weirdness).
> 
> If noone is using these configurations, then I think this patch is fine. If not, we will have to do something more elaborate. I suspect it's safe, but lets wait a while before committing to give people a chance to notice this.

Do you think it should be pushed now?

https://github.com/llvm/llvm-project/pull/99589