[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

[via lldb-commits]

jimingham wrote:



> On Jul 25, 2024, at 3:34 PM, Greg Clayton ***@***.***> wrote:
> 
> 
> @clayborg commented on this pull request.
> 
> In lldb/include/lldb/API/SBProcess.h <https://github.com/llvm/llvm-project/pull/99736#discussion_r1692222602>:
> 
> > -  lldb::SBError Continue();
> +  lldb::SBError Continue(RunDirection direction = RunDirection::eRunForward);
> @jimingham <https://github.com/jimingham>: do you want all process control function to remain the same and then add a direction control? Something like:
> 
> lldb::SBError SetRunDirection(RunDirection direction);
I'm on the fence about whether to do add a "direction API", or add variants that pass the direction to the forward motion API's (SBThread.StepOver, etc.)  They will all need to be told this.  Would it be better to write:

process->SetRunDirection(lldb.eRunForward)
thread->StepOver()

or 

thread->StepOver(lldb.eRunForward)

Buf for sure, whatever we do, we can't change SBThread.StepOver(), we have to add a non-defaulted API SBThread.StepOver(RunDirection).

Jim

> Jim is this what you are thinking?
> 
> And my API comments stand though, we can't change a pre-existing API. We can add new overloads though
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/99736#discussion_r1692222602>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVWYB26WIZNTBB2POV3DZOF4ORAVCNFSM6AAAAABLFTBQAKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBQGU3DQMRQHE>.
> You are receiving this because you were mentioned.
> 



https://github.com/llvm/llvm-project/pull/99736