[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 25 16:39:00 PDT 2024


================
@@ -75,6 +77,18 @@ lldb::SaveCoreStyle SBSaveCoreOptions::GetStyle() const {
   return m_opaque_up->GetStyle();
 }
 
+SBError SBSaveCoreOptions::SetProcess(lldb::SBProcess process) {
+  return m_opaque_up->SetProcess(process.GetSP());
+}
+
+SBError SBSaveCoreOptions::AddThread(lldb::SBThread thread) {
+  return m_opaque_up->AddThread(thread.get());
----------------
Jlalond wrote:

Added this, and explicitly kept it lower case for the convention. Should we open an issue to look for casts to pointer and then `GetSP()` and clean them up?

https://github.com/llvm/llvm-project/pull/100443


More information about the lldb-commits mailing list