[Lldb-commits] [lldb] [lldb][Linux] Parse, but don't store "comm" from /proc/stat file (PR #100387)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 25 01:07:30 PDT 2024


https://github.com/labath approved this pull request.

Yikes, I didn't realize this was new code. @feg208, we need to fix this soon.

I'm approving this because it strictly improves upon the current situation, but I don't think it's not a complete fix. I think we can skip over the `comm` field with a `rsplit(')')`. The rest could be parsed with scanf, as it's kinda convenient -- even if old-fashioned. (A more modern approach would be either with std::istringstream or some combination of StringRef::consumeInteger, StringRef::ltrim, llvm::split and friends

https://github.com/llvm/llvm-project/pull/100387


More information about the lldb-commits mailing list