[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

Robert O'Callahan via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 22 15:04:30 PDT 2024


================
@@ -3281,7 +3288,11 @@ Status Process::PrivateResume() {
             "Process::PrivateResume PreResumeActions failed, not resuming.");
       } else {
         m_mod_id.BumpResumeID();
-        error = DoResume();
+        if (direction == eRunForward) {
+          error = DoResume();
----------------
rocallahan wrote:

The advantage of separate `DoResume()` and `DoResumeReverse()` methods is that `Process` subclasses that don't support reverse execution don't have to change at all; they inherit the default `DoResumeReverse()` that returns an error. If I make `DoResume()` take a direction parameter then those implementations (three out of four AFAICT) need to add a check of the direction parameter. It's not a big deal, I'll change it.

https://github.com/llvm/llvm-project/pull/99736


More information about the lldb-commits mailing list