[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

[Alex Langford via lldb-commits]

================
@@ -15,8 +15,8 @@
 namespace lldb_private {
 class ScriptedMetadata {
 public:
-  ScriptedMetadata(llvm::StringRef class_name,
-                   StructuredData::DictionarySP dict_sp)
+  ScriptedMetadata(const llvm::StringRef class_name,
+                   const StructuredData::DictionarySP dict_sp)
       : m_class_name(class_name.data()), m_args_sp(dict_sp) {}
----------------
bulbazord wrote:

Not related to this PR, but we should probably be initializing `m_class_name` with `class_name.str()` and not `class_name.data()`.

https://github.com/llvm/llvm-project/pull/99814