[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 17 20:30:20 PDT 2024
================
@@ -355,11 +355,10 @@ size_t ObjectFilePECOFF::GetModuleSpecifications(
}
bool ObjectFilePECOFF::SaveCore(const lldb::ProcessSP &process_sp,
- const lldb_private::FileSpec &outfile,
- lldb::SaveCoreStyle &core_style,
+ const lldb_private::CoreDumpOptions &options,
lldb_private::Status &error) {
- core_style = eSaveCoreFull;
- return SaveMiniDump(process_sp, outfile, error);
+ assert(options.GetOutputFile().has_value());
----------------
clayborg wrote:
Add same comment and add `assert(process_sp);`
https://github.com/llvm/llvm-project/pull/98403
More information about the lldb-commits
mailing list