[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

[Greg Clayton via lldb-commits]

================
@@ -56,18 +56,20 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
 }
 
 bool ObjectFileMinidump::SaveCore(const lldb::ProcessSP &process_sp,
-                                  const lldb_private::FileSpec &outfile,
-                                  lldb::SaveCoreStyle &core_style,
+                                  const lldb_private::CoreDumpOptions &options,
                                   lldb_private::Status &error) {
-  // Set default core style if it isn't set.
-  if (core_style == SaveCoreStyle::eSaveCoreUnspecified)
-    core_style = SaveCoreStyle::eSaveCoreStackOnly;
-
+  assert(options.GetOutputFile().has_value());
   if (!process_sp)
     return false;
----------------
clayborg wrote:

Might as well check this in the plugin manager and assert(process_sp) with an appropriate comment like we did above.

https://github.com/llvm/llvm-project/pull/98403