[Lldb-commits] [lldb] [lldb] IRMemoryMap zero address mapping fix (PR #99045)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

To make sure I'm clear: I don't have a problem with the basic idea of the change, although we could comment what is going on more clearly, and I'm curious about that qMemoryRegionInfo packet.  But it looks like you're connecting to a device which can't allocate memory through gdb remote serial protocol (common for jtag/vm type stubs), but can report memory region info (much less common, it's an lldb extension I believe), and the memory region at address 0 is reported as being inaccessible (reasonable).  So the IRMemoryMap is trying to use address 0 and that overlaps with actual addresses seen in the process, leading to confusion.  

Most similar environments, that can't allocate memory, don't support qMemoryRegionInfo so we pick one of our bogus addresses ranges (in higher memory) to get a better chance of avoiding actual program addresses.

https://github.com/llvm/llvm-project/pull/99045