[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

[Pavel Labath via lldb-commits]

================
@@ -56,15 +57,12 @@ LLDB_BASE_DIR := $(THIS_FILE_DIR)/../../../../../
 # inherited all the way down to the process spawned for make.
 #----------------------------------------------------------------------
 ifeq "$(HOST_OS)" ""
-  HOST_OS := $(shell uname -s)
-endif
-
-ifneq (,$(findstring windows32,$(HOST_OS)))
-	HOST_OS := Windows_NT
-endif
-
-ifneq (,$(findstring MSYS_NT,$(HOST_OS)))
-	HOST_OS := Windows_NT
+    HOST_OS := $(shell uname -s)
+    ifneq (,$(or \
+            $(findstring windows32,$(HOST_OS)),\
+            $(findstring MSYS_NT,$(HOST_OS))))
+        HOST_OS := Windows_NT
+    endif
----------------
labath wrote:

Why do we need to do this if we're already setting HOST_OS in python (7021e44b2f0e11717c0d82456bad0fed4a0b48f9)? If the python code is not sufficient, could we fix it (and delete this code) to keep everything in one place?

https://github.com/llvm/llvm-project/pull/99266