[Lldb-commits] [lldb] [lldb] progressive progress reporting for darwin kernel/firmware (PR #98845)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 16 16:33:10 PDT 2024


================
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec &file_spec,
   ModuleSP module_sp(new Module(file_spec, ArchSpec()));
   if (module_sp) {
     Status error;
+    std::unique_ptr<Progress> progress_up;
+    if (!GetCoreFile())
----------------
clayborg wrote:

Might be better to use the bool accessor function:
```
if (IsLiveDebugSession())
```

https://github.com/llvm/llvm-project/pull/98845


More information about the lldb-commits mailing list